Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix palette effects on RA desert buildings/rocks #16500

Merged
merged 1 commit into from May 12, 2019

Conversation

@reaperrr
Copy link
Contributor

commented May 4, 2019

Fixes #15759.
Fixes #16311.

@reaperrr reaperrr added this to the Next Release milestone May 4, 2019

@pchote
pchote approved these changes May 4, 2019

@pchote pchote added the PR: Needs +2 label May 4, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@matjaeck Could you take a quick look at this?

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Sorry, I don't know anything about palettes so can't help.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

I meant can you test & confirm that it fixes the two issues I listed (without introducing new visible regressions)?

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Ok, I take a look at it now.

@matjaeck
Copy link
Contributor

left a comment

Issues are fixed and I didn't spot anything strange.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

Thanks!

@reaperrr reaperrr merged commit a403d99 into OpenRA:bleed May 12, 2019

3 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.