Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mines will no longer damage each other #16514

Merged
merged 1 commit into from May 18, 2019

Conversation

@Punsho
Copy link
Contributor

commented May 7, 2019

Mines sometimes explode in a chain wasting their damage potential. This also means that clearing them out is made a lot easier. Mines are currently underused and this is a small buff to them.

Mines are an exception

  1. They are not a structure as they cannot be built in the production queue nor be captured
  2. They are not a unit as they're completely stationary

The cleanest way we found on Discord to remove friendly fire was to make a new target type "Mine"

@ZxGanon

This comment has been minimized.

Copy link

commented May 11, 2019

It fixes a problem that we had in SP and RV (where Mines basically cleared out each other).

Edit:
If not enough Mines could maybe receive their own type/ArmorType since they will also damage buildings at this point.

@Punsho Punsho force-pushed the Punsho:MineFriendlyFire branch 3 times, most recently from 54fa338 to 825f896 May 11, 2019

@Punsho Punsho force-pushed the Punsho:MineFriendlyFire branch from 825f896 to 510e2c3 May 15, 2019

@Punsho

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

Sorry about that @Smittytron, a spelling mistake was made

@abcdefg30
Copy link
Member

left a comment

Looks good to me otherwise.

mods/ra/weapons/smallcaliber.yaml Show resolved Hide resolved

@abcdefg30 abcdefg30 merged commit 336cfed into OpenRA:bleed May 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented May 18, 2019

@Punsho Punsho deleted the Punsho:MineFriendlyFire branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.