Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaged mono to 5.20.1.19 #16516

Merged
merged 2 commits into from May 19, 2019

Conversation

@pchote
Copy link
Member

commented May 7, 2019

Fixes #16512.

This PR updates the mono version used by travis and shipped in the AppImages and mac .apps to the latest stable release.

The base platform for building the Linux dependencies (pulled from the AppImageSupport repo by the packaging scripts) is also changed from Debian 7 to Ubuntu 14.04 because the Debian 7 update servers have been taken offline, breaking the automated compilation.

This change also raises our minimum macOS version requirement from 10.7 to 10.9 because mono >= 5.18 have dropped support for these old versions (10.8 was released in 2012 and EOLed in 2015). The sysinfo stats for 2019 showed < 10 systems affected, and these players will still have the option of installing mono 5.16 and compiling OpenRA from source.

This also fixes travis downloading and installing the NSIS packages before every build - these are only needed during release packaging.

Test builds are available from https://github.com/pchote/OpenRA/releases/tag/pkgtest-20190506

@pchote pchote added this to the Next Release milestone May 7, 2019

@fusion809

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Is that forum login issue still present in an AppImage built using this PR?

@fusion809

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

I just tested it on Arch and that forum bug is gone.

@pchote pchote force-pushed the pchote:mono-five-twenty branch from 3114f47 to 876d96a May 9, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Rebased.

@fusion809
Copy link
Contributor

left a comment

On Linux this works fine, and while I do not follow the moving of the NDIS lines, I can confirm on Linux buildpackage.sh builds the AppImage fine and this AppImage runs fine. I can also confirm that after the latest commits are applied the AppImages built from this PR still run fine on Linux,.

@pchote pchote added the PR: Needs +2 label May 15, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented May 19, 2019

I tested this on all platforms before PRsing and @fusion809 has further confirmed correct behaviour on additional Linux distros. Its not clear who would give this a second 👍 so there's not much to gain by keeping this open indefinitely.

@pchote pchote merged commit 327fdae into OpenRA:bleed May 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.