Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Write-Host instead of echo #16529

Merged
merged 1 commit into from May 16, 2019

Conversation

@teinarss
Copy link
Contributor

commented May 11, 2019

Closes #16517

@pchote

This comment has been minimized.

Copy link
Member

commented May 11, 2019

We use echo in a bunch of other places in the script, and i'm pretty sure they work. Why do these ones not?

@pchote

This comment has been minimized.

Copy link
Member

commented May 11, 2019

Is there any reason not to use write-host to replace all echos?

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

@teinarss teinarss force-pushed the teinarss:make_check_dotnet branch from d60403c to e605a94 May 12, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2019

Updated

@pchote pchote requested review from abcdefg30 and reaperrr May 12, 2019

make.ps1 Outdated Show resolved Hide resolved

@teinarss teinarss force-pushed the teinarss:make_check_dotnet branch 2 times, most recently from 1303c41 to 3c1441c May 12, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented May 12, 2019

Not tested in more detail yet, but

[00:37] <+reaperrr> btw pchote, I forgot where [RequireExplicitImplementation] would trigger if something is not explicit, was it during compile, check or test?
[00:38] <+reaperrr> could that have regressed due to the make/csproj refactor?
[00:38] <+pchote> its the --check-explicit-interfaces utility rule, which is run in check
[00:38] <+pchote> and possibly
[00:38] <+pchote> but more likely related to #16529

might also be related.

@abcdefg30
Copy link
Member

left a comment

Looks good to me.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

One nit: Could we use Cyan instead of Blue? On my screen Blue is dark enough that it's rather hard to read against the black background.
👍 after that.

@teinarss teinarss force-pushed the teinarss:make_check_dotnet branch from 3c1441c to b5debdd May 16, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Updated

@reaperrr reaperrr merged commit 70f0075 into OpenRA:bleed May 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.