Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powershell if statements not checking the return value of calls #16537

Merged
merged 1 commit into from May 16, 2019

Conversation

@abcdefg30
Copy link
Member

commented May 13, 2019

If you don't put the call into parenthesis, the comparison operand will be passed along as argument.

@abcdefg30 abcdefg30 requested a review from reaperrr May 13, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

I guess this fixes #16517?

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

No, we still need #16529.

@teinarss
Copy link
Contributor

left a comment

Works and also fixes:

[00:37] <+reaperrr> btw pchote, I forgot where [RequireExplicitImplementation] would trigger if something is not explicit, was it during compile, check or test?
[00:38] <+reaperrr> could that have regressed due to the make/csproj refactor?
[00:38] <+pchote> its the --check-explicit-interfaces utility rule, which is run in check
[00:38] <+pchote> and possibly
[00:38] <+pchote> but more likely related to #16529

@reaperrr reaperrr merged commit e888a23 into OpenRA:bleed May 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:ifCall branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.