Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple clients being assigned as admin. #16550

Merged
merged 1 commit into from May 22, 2019

Conversation

@pchote
Copy link
Member

commented May 17, 2019

Fixes #16395.

A simple way to reproduce the issue:

  1. Add Thread.Sleep(10000) at the top of onQueryComplete in ValidateClient
  2. Start a local dedicated server
  3. Start two clients
  4. Make both clients join the dedicated server within the 10s join window

@pchote pchote added this to the Next Release milestone May 17, 2019

@teinarss
Copy link
Contributor

left a comment

Working as intended!

@abcdefg30 abcdefg30 merged commit 217221d into OpenRA:bleed May 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@pchote pchote deleted the pchote:fix-double-admin branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.