Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a global script in Tiberian Dawn #16568

Merged
merged 4 commits into from Dec 20, 2019
Merged

Use a global script in Tiberian Dawn #16568

merged 4 commits into from Dec 20, 2019

Conversation

@abcdefg30
Copy link
Member

abcdefg30 commented May 19, 2019

Supersedes #15946.
Makes use of #16277 in TD.

Closes #9456.
Closes #16833.

I ported all maps to nod05 - the rest will follow soon, hopefully.

Values:
normal: Normal
Default: normal
#Locked: true

This comment has been minimized.

Copy link
@abcdefg30

abcdefg30 May 19, 2019

Author Member

This will be restored once I ported all missions.

@fruestueck

This comment has been minimized.

Copy link
Contributor

fruestueck commented Jul 26, 2019

Could you add guard.Stop() before guard.Guard(building) in the GuardBase function of mission nod08a-AI.lua, nod08b-AI.lua and nod09-AI.lua when you're at it.

The Orcas guarding the GDIBase will get really confused when you attack two different buildings several times.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:tdScript branch 4 times, most recently from a2631f3 to e4a599a Sep 28, 2019
@abcdefg30 abcdefg30 marked this pull request as ready for review Oct 2, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Oct 2, 2019

Updated. This covers all missions now. Most of the AI stuff is still somewhat bogus, but will be replaced anyway once we have settled on an approach in #17129.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:tdScript branch from e4a599a to e5515a9 Oct 3, 2019
@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 12, 2019

@abcdefg30 Have you tested all missions yourself (or anyone else)?

I'm asking because I don't have the time to do that myself, and the sheer size of the PR plus my own limited lua experience makes a "reading only" review unreliable at best, so the only chance I see to get this merged without splitting it into a series of smaller PRs would be if we could get confirmation from you and/or other testers that the missions indeed still work.

@abmyii

This comment has been minimized.

Copy link
Contributor

abmyii commented Dec 12, 2019

Have you tested all missions yourself (or anyone else)?

I'd be happy to chip in if there are too many maps for @abcdefg30 to test alone.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Dec 12, 2019

I did play every mission back in October (latest revision of this PR).
@abmyii playtesting would still be appreciated (just to make sure there are no silly crashes that I overlooked).

@abmyii

This comment has been minimized.

Copy link
Contributor

abmyii commented Dec 12, 2019

Tried the first three missions - all good!

@abcdefg30 abcdefg30 force-pushed the abcdefg30:tdScript branch from e5515a9 to 9da9fbb Dec 19, 2019
@abcdefg30

This comment has been minimized.

Copy link
Member Author

abcdefg30 commented Dec 19, 2019

Rebased.

Copy link
Contributor

reaperrr left a comment

LGTM

@reaperrr reaperrr merged commit bb85146 into OpenRA:bleed Dec 20, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30 abcdefg30 deleted the abcdefg30:tdScript branch Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.