Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around C17s and Frigates not being able to deliver units #16574

Merged
merged 4 commits into from Jun 4, 2019

Conversation

@abcdefg30
Copy link
Member

commented May 21, 2019

Currently no units are delivered since the plane never lands.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:airstrip branch from f6545d3 to b932517 May 21, 2019

@pchote pchote added this to the Next Release milestone May 21, 2019

@abcdefg30 abcdefg30 force-pushed the abcdefg30:airstrip branch from d1fcd3e to 2d9ab72 May 21, 2019

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

You can test the ticket with selling the airstrip after the production finished but before the plane landing.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

Then it appears to be already fixed on bleed.

@pchote
Copy link
Member

left a comment

The D2k starport suffers from the same bug. Can you please fix that here too?

mods/cnc/rules/aircraft.yaml Outdated Show resolved Hide resolved
mods/cnc/rules/aircraft.yaml Outdated Show resolved Hide resolved

@abcdefg30 abcdefg30 force-pushed the abcdefg30:airstrip branch from 2d9ab72 to 53f2539 May 23, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

Updated.

@abcdefg30 abcdefg30 changed the title Work around C17s not being able to deliver units Work around C17s and Frigates not being able to deliver units May 23, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented May 23, 2019

#16239 was filed based on playtest-20190209, well before the landing changes. Removed the reference from the PR description that would have automatically closed the issue.

@pchote

This comment has been minimized.

Copy link
Member

commented May 23, 2019

This fix reveals a second regression: If a second plane arrives while the first is landing it will be blocked, and do a loop before landing. We can introduce an OccupiesSpace flag on AircraftInfo that disables the ActorMap influence adding/removing.

@pchote

This comment has been minimized.

Copy link
Member

commented May 23, 2019

A third landing terrain type regression was noted in #16481.

idle yaks will not respond to queued orders (we had this issue before)

This issue is present in bleed as well and was regressed by #16365. the problem is that LandWhenIdle defaults to true even for aircraft that have no valid terrain for landing, so the aircraft gets stuck in a holding pattern until canceled. This should be handled in a separate fixup PR.

@tovl

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

The last issue was already fixed in #16509 . Also, the work-arounds proposed here would heavily conflict with that PR. Expect a proper fix to be added soon to that PR or a follow up.

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented May 24, 2019

This fix reveals a second regression: [...]

This was not unexpected, as I said on IRC yesterday.

@pchote
pchote approved these changes Jun 4, 2019
Copy link
Member

left a comment

This bug is blocking meaningful testing of the AI, so we need a fix ASAP.
We can revert parts of this again in #16509 once that is ready.

@pchote pchote added the PR: Needs +2 label Jun 4, 2019

@matjaeck
Copy link
Contributor

left a comment

Fixes the bug.

@reaperrr reaperrr merged commit bf6fa94 into OpenRA:bleed Jun 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:airstrip branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.