Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces RunConfiguration and Configuration with launchSettings.json #16575

Merged
merged 1 commit into from May 22, 2019

Conversation

@teinarss
Copy link
Contributor

commented May 21, 2019

No description provided.

@teinarss teinarss force-pushed the teinarss:launchsettings branch from d1181ea to ad590cd May 21, 2019

@pchote
Copy link
Member

left a comment

This works nicely in Rider, and will fix the confusion in MD thanks to that not exposing the launchSettings at all with vs/rider not exposing the RunConfigurations at all.

So LGTM with the fixes below. I'll have a followup after this to handle the other MD regressions.

OpenRA.Game/OpenRA.Game.csproj Outdated Show resolved Hide resolved
OpenRA.Game/OpenRA.Game.csproj Show resolved Hide resolved

@teinarss teinarss force-pushed the teinarss:launchsettings branch from ad590cd to e6216eb May 21, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

Updated!

@pchote
pchote approved these changes May 21, 2019
Copy link
Member

left a comment

Works nicely on Rider, VS:Mac, and MonoDevelop 7.8.2.

Note that VS:Mac and MD require an additional fix for #16534, which I will be PRing alongside some other changes after this.

@abcdefg30 abcdefg30 merged commit 881cacb into OpenRA:bleed May 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.