Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default support dir location on Windows and Linux #16587

Merged
merged 1 commit into from May 26, 2019

Conversation

@pchote
Copy link
Member

commented May 23, 2019

This PR revises our support dir locations to match modern platform conventions:

Windows: SpecialFolder.ApplicationData (i.e. C:\Users\<user>\AppData\Roaming\OpenRA)
Linux: $XDG_CONFIG_HOME (i.e. ~/.config/openra)
macOS: unchanged

Fixes #16267.
Partially addresses #10374.

The previous support dir locations are kept for existing users, so there is no need to copy settings or reinstall data.

Change default support dir location on Windows and Linux:
Windows now prefers the ApplicationData directory
Linux now prefers XDG_CONFIG_HOME

Fall back to the previous directory to avoid data loss or duplication.

@pchote pchote added this to the Next Release milestone May 23, 2019

@pchote pchote changed the title Change default support dir location on Windows and Linux: Change default support dir location on Windows and Linux May 23, 2019

@matjaeck
Copy link
Contributor

left a comment

Works on Ubuntu 18.04, tested with an existing and without existing support dir and everything worked as expected.

@teinarss

This comment has been minimized.

Copy link
Contributor

commented May 26, 2019

tested the same on win10.

@abcdefg30 abcdefg30 merged commit aed6098 into OpenRA:bleed May 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented May 26, 2019

@pchote pchote deleted the pchote:modern-supportdir branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.