Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WithSpriteBody crashes #16610

Merged
merged 1 commit into from May 29, 2019

Conversation

@abcdefg30
Copy link
Member

commented May 29, 2019

by moving references to DefaultAnimation.CurrentSequence into TraitEnabled.
Fixes #16609.

@abcdefg30 abcdefg30 added this to the Next Release milestone May 29, 2019

fusion809 added a commit to fusion809/openra-git that referenced this pull request May 29, 2019
fusion809 added a commit to fusion809/OpenRA that referenced this pull request May 29, 2019
fusion809 added a commit to fusion809/OpenRA that referenced this pull request May 29, 2019

@ltem ltem added the PR: Needs +2 label May 29, 2019

@fusion809
Copy link
Contributor

left a comment

This improvement fixes the bug for me too. I've even created packages/installers for this commit, so that if anyone wants to test it out and are not on a system where they can easily manually build this PR they can still try it out—https://github.com/fusion809/OpenRA/releases/tag/untagged-6efb55fd238d3ab44e8e.

@pchote
pchote approved these changes May 29, 2019

@pchote pchote merged commit 1c965d8 into OpenRA:bleed May 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fusion809 added a commit to fusion809/OpenRA that referenced this pull request May 29, 2019

@abcdefg30 abcdefg30 deleted the abcdefg30:turr branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.