Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Aircraft firstTick logic #16641

Merged
merged 1 commit into from Jun 9, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Jun 6, 2019

See commits for details.

@pchote pchote added the PR: Needs +2 label Jun 8, 2019

@matjaeck
Copy link
Contributor

left a comment

This changes the behavior when a plane is ready to exit while the airfield is used:

bleed:

bleedtakeoff

PR:
prtakeoff

Same without cheats. I'm not sure if I'd call it a regression, but if we allow to exit when the airfield is used, we should also allow to exit when the airfield is reserved.

Improve Aircraft firstTick code
- Remove ReserveSpawnBuilding:
Only used in one place, and removing it
avoids a double GetActorBelow() look-up.

- Remove FallsToEarth check form Aircraft.firstTick:
Aircraft triggers UnReserve() on actor disposal,
so this work-around should no longer be necessary.

@reaperrr reaperrr force-pushed the reaperrr:sanitize-aircraft-tick1 branch from 0aedd3a to b713984 Jun 8, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Fixed and squashed commits.

@pchote
pchote approved these changes Jun 9, 2019

@pchote pchote merged commit 97084ef into OpenRA:bleed Jun 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.