Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust height of multiplayer-browser chrome #16643

Merged

Conversation

@dragunoff
Copy link
Contributor

commented Jun 6, 2019

This PR adjusts the multiplayer browser panel height to be in line with the rest of the large panels. I guess it was made shorter intenionally when the dropdown for filtering games was introduced. This however created a visual jump in the UI when clicking the "Leave Game" button in a lobby. A picture that explains it:

изображение

Since the filter dropdown would no longer fit on a 768px tall viewport I made the widget open upwards if it were to be clipped by the viewport:

изображение

A small step towards #16596

@abcdefg30
Copy link
Member

left a comment

Looks good to me.

@reaperrr reaperrr merged commit caa440c into OpenRA:bleed Jun 29, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.