Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support power palette order #16645

Merged
merged 2 commits into from Jun 15, 2019

Conversation

@dragunoff
Copy link
Contributor

commented Jun 6, 2019

As suggested in #16383 and discussed on discord around the same time. This is very similar to BuildPaletteOrder. The order is as follows:

Index RA TD d2k
10 Spy Plane Airstrike Airstrike
20 Paradrop Ion Canon Fremen
30 Parabombs Nuke Saboteur
40 Iron Curtain Nuke
50 Chronoshift
60 Adv. Chronoshift
70 Nuke
80 Sonar Pulse
90 GPS

I have not ordered the TS powers because not all have been implemented yet.

@abcdefg30
Copy link
Member

left a comment

Is there a specific reason you didn't apply this to TS?

@pchote

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

I have not ordered the TS powers because not all have been implemented yet.

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Derp, I can't read any more apparently.

@dragunoff dragunoff force-pushed the dragunoff:feature/support-power-palette-order branch from e3f64bf to 1536acc Jun 7, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

Rebased and updated with requested changes.

@pchote
Copy link
Member

left a comment

Minor code style nit, otherwise LGTM.

@dragunoff dragunoff force-pushed the dragunoff:feature/support-power-palette-order branch from 1536acc to 903d881 Jun 9, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Rebased and addressed style nits.

@matjaeck
Copy link
Contributor

left a comment

LGTM.

@Orb370

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

The original reason I brought this up is because Chronoshift/Iron Curtain are time sensitive superpowers but often their hotkeys are different depending on what faction you are, and inconsistent depending on unlock order.

I think both superpowers should be first, that way no matter what other superpowers you have at least your hotkey will stay consistent.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

This is what I'm proposing here (allies, soviets, double tech):
изображение

@Orb370 If I understand you correctly you are suggesting that IC and chrono be at the top because they are the most time sensitive powers and should always be available via a hotkey (as there are only 4 hotkeys)?

@Orb370

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Yes. But also for people who play different factions, IC/Chrono will be on 3 different hotkeys depending on the faction. Ukraine, Russia, and Any Allied Faction respectively.

If it's always at the top then it doesn't matter what faction you are playing.

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Yes. But also for people who play different factions, IC/Chrono will be on 3 different hotkeys depending on the faction. Ukraine, Russia, and Any Allied Faction respectively.

If it's always at the top then it doesn't matter what faction you are playing.

Not quite. The order of the powers does not directly correlate with the hotkey slots: If you only have one power, that power will always be in slot one. The support power slot hotkey always relates to the actual available powers, and only then to their order. So it is very possible that the hotkey for your powers change during the game (i.e. building an airfield before the nuke).

Would it make sense to start with the strongest power, something like this?

Index RA
10 Nuke
20 Iron Curtain
30 Adv. Chronoshift
40 Chronoshift
50 Parabombs
60 Paradrop
70 Spy Plane
80 Sonar Pulse
90 GPS

(I still keep my +1 up since I don't see any big gain from changing the order since the hotkeys are not bound to the order)

@Orb370

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

That is why I suggest moving them to the front. That way, it always slots into the first slot, regardless of what support powers you have.

Nukes have a long cooldown, take a long time to reach their target, and are a fire and forget. I think the original ordering is fine as far as that is concerned. I don't think I'd ever lose/win a game if I delayed my nuke by several seconds, but a IC/Chronoshift delayed by even a fraction of a second can make the difference.

@matjaeck
Copy link
Contributor

left a comment

I think @Orb370 has a point here. When we move the nuke and ic/chrono up they will always be on the same hotkeys once they are build, which does make things easier.

@pchote

This comment has been minimized.

Copy link
Member

commented Jun 9, 2019

👍 to putting IC/Chrono first, then nuke, then everything else.

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

I agree with @Orb370. IC/Chrono usage is very time senstive and having a consistent hotkey (except in doble tech scenarios) can help with that. So something like this:

Index RA
10 Iron Curtain
20 Chronoshift
30 Adv. Chronoshift
40 Parabombs
50 Paradrop
60 Spy Plane
70 Nuke
80 Sonar Pulse
90 GPS

Which results in this in-game (doble tech, allies, soviet):
изображение

  • Getting both chronoshift and adv. chronoshift would be a very rare case so the second chronoshift here can be mostly igrnored.
  • Nuke is near the bottom because games often don't reach that stage and if it had a higher priority it would disrupt the order when it becomes available. And as mentioned already - it has a long cooldown and usually the player has enough time to choose the target w/out a hotkey. Up for debate of course.
@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

To me it would make more sense to have the nuke / ic / chrono all in the first slots (IMO ordered by strenth and have the nuke in slot 1) but you got a point with

if it had a higher priority it would disrupt the order when it becomes available

So I'm fine with both ways.

@dragunoff dragunoff force-pushed the dragunoff:feature/support-power-palette-order branch from 903d881 to 8ea15e9 Jun 9, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Updated with the new order for RA as discussed.

@matjaeck
Copy link
Contributor

left a comment

Looks good with IC at start and nuke at bottom.

@abcdefg30 abcdefg30 merged commit 9f59b00 into OpenRA:bleed Jun 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

@dragunoff dragunoff deleted the dragunoff:feature/support-power-palette-order branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.