Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split attack aspect of CanHover to AttackType on AttackAircraft #16671

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Jun 9, 2019

On bleed, CanHover currently affects 3 main aspects of aircraft behavior:

  • how does it change flight direction (instant with only visual turning, or flying real curves)
  • how does it move on attack (hovering or strafing)
  • how does it move on idle (hover in place or circle, if LandWhenIdle is false)

However, there are cases - even in our official mods, namely D2k carryalls and TS Orca/Harpy - where we want some, but not all of bleed's CanHover behavior.

This PR splits the attack movement control to an AttackType on AttackAircraft (the other cases will be handled differently, in a separate PR).

Yaml changes were done via update rule.

@pchote pchote added this to the Next Release milestone Jun 9, 2019

@tovl

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Looks good. Can we maybe change the name CanChangeDirectionWithoutTurning to something less verbose, like CanSlide?

EDIT: Ninja'd

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Looks good. Can we maybe change the name CanChangeDirectionWithoutTurning to something less verbose, like CanSlide?

Fine by me, I wasn't happy with that name either but couldn't come up with anything better.

Introduce AirAttackType
Aircraft attack behavior (currently FlyBy or Hover)
is now controlled via this instead of the CanHover boolean.

@reaperrr reaperrr force-pushed the reaperrr:CanHover-breakup branch from 8c9d159 to 2690f01 Jun 10, 2019

@reaperrr reaperrr changed the title CanHover logic split Split attack aspect of CanHover to AttackType on AttackAircraft Jun 10, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

Updated.

Removed the 'CanSlide' part, that will come in a separate PR following @pchote's FlightDynamics suggestion.

@pchote
pchote approved these changes Jun 10, 2019

@pchote pchote added the PR: Needs +2 label Jun 10, 2019

@tovl
tovl approved these changes Jun 10, 2019
Copy link
Contributor

left a comment

LGTM

@abcdefg30 abcdefg30 merged commit c8a42cb into OpenRA:bleed Jun 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.