Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undeploy orders always being queued. #16677

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@pchote
Copy link
Member

commented Jun 10, 2019

Fixes #16674.

@pchote pchote added this to the Next Release milestone Jun 10, 2019

@matjaeck
Copy link
Contributor

left a comment

Fixes the bug and seems to work otherwise.

@tovl
tovl approved these changes Jun 10, 2019
Copy link
Contributor

left a comment

Fix confirmed. We might want to change the move cursor to not show as blocked in this case as well. Otherwise 👍

This still leaves the bug that deploy orders cannot be queued while the undeploy animation plays, but that doesn't need to be fixed here.

@abcdefg30 abcdefg30 merged commit a8b7fca into OpenRA:bleed Jun 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

@pchote pchote deleted the pchote:fix-undeploy-orders branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.