Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ReloadAmmoDelayMultiplier #16707

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Jun 17, 2019

I have recently decided to write a new manager trait for the Sole Survivor mod multipliers, so i can implement team bonuses and properly revoke the bonuses when taking Wacky Crates or Flags.

On other hand, since i'm no longer using conditions, i can't make Reload Delay bonus properly apply the Mobile SSM/Orca/Apache since those units use Ammo Pools. So i implemented ReloadAmmoDelayMultiplier and IReloadAmmoMultiplier interface to use there.

We may also wanna use this on the default mods for the same reason the veterancy bonus don't change the ammo reload of some units and default mods don't have multipile ReloadAmmoPool traits like i used to use in SS either.

TESTCASE makes it so Orca reloads 4 times faster when you have a normal or advanced communications center in TD. Ignore the changes to TS, it was for testing #16678 and sneaked in. It is a part of the TESTCASE commit i can just remove it along with the TESTCASE.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

👍 after testcase is removed.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:reload-ammo-multiplier branch from 258cc15 to 8b5f12a Jun 28, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Removed testcase.

@reaperrr reaperrr merged commit d369731 into OpenRA:bleed Jun 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:reload-ammo-multiplier branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.