Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DetectCloakedMultiplier #16708

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Jun 17, 2019

Similar story to #16707.

TESTCASE makes it so having Radar Dome or Allied Tech Center increase cloak detection range of Radar Jammer.

@netnazgul

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Test case will be removed from actual PR, right? ;)

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

Yes. This PR doesn't have a second 👍 yet though, so I would keep it for the next person testing it.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

👍 after that minor fix and test case removal.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:detect-cloaked-multiplier branch from 5fb400f to ab5eeed Jun 28, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Updated and removed the testcase.

@reaperrr reaperrr merged commit 3e39ada into OpenRA:bleed Jun 28, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:detect-cloaked-multiplier branch Jun 28, 2019

public DetectCloaked(DetectCloakedInfo info)
: base(info) { }

void INotifyCreated.Created(Actor self)

This comment has been minimized.

Copy link
@GraionDilach

GraionDilach Jul 13, 2019

Contributor

Doesn't this explicitly override ConditionalTrait.INotifyCreated.Created and should have been a protected override Created method starting with base.Created with no INotifyCreated interface implementation within this file?

This comment has been minimized.

Copy link
@reaperrr

reaperrr Jul 13, 2019

Contributor

Good catch.
Should have been

		protected override void Created(Actor self)
		{
			rangeModifiers = self.TraitsImplementing<IDetectCloakedModifier>().ToArray();

			base.Created(self);
		}

This comment has been minimized.

Copy link
@pchote

pchote Jul 13, 2019

Member

This is also a problem for AutoTarget, PrimaryBuilding, GrantConditionOnDeploy, Explodes, KillsSelf, ReloadAmmoPool, ActorSpawnManager, Chronoshiftable, ResourcePurifier.

I am working on a lint check that will prevent this from happening again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.