Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some doc errors in VS2019. #16716

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@RoosterDragon
Copy link
Member

commented Jun 20, 2019

Needed to suppress some style rules which VS2019 is reporting as errors. Fixed rules with only one or two breakages and suppressed the rest.

(I figure this must be VS specific or it would've otherwise been noted by now...)

@RoosterDragon RoosterDragon force-pushed the RoosterDragon:fix-doc-style branch from 2cc820f to e0effce Jun 20, 2019

@pchote
pchote approved these changes Jun 20, 2019
Copy link
Member

left a comment

LGTM and confirmed that nothing changes when compiled using Rider or make check on macOS.

@pchote pchote added the PR: Needs +2 label Jun 20, 2019

@pchote pchote added this to the Next Release milestone Jun 20, 2019

@teinarss teinarss referenced this pull request Jun 20, 2019

@reaperrr reaperrr merged commit 58dced7 into OpenRA:bleed Jun 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@RoosterDragon RoosterDragon deleted the RoosterDragon:fix-doc-style branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.