Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostProcess command to handle paths with spaces. #16718

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@RoosterDragon
Copy link
Member

commented Jun 20, 2019

Fixes #16665.

Mere single quotes were not magical enough, double quotes are required. " is the escaped form.

@pchote pchote added this to the Next Release milestone Jun 20, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

This doesn't seem to help on macOS, but i'm not sure what is going wrong...

bleed (fails with expected error):

  OpenRA.PostProcess -> /Users/paul/src/Open RA/OpenRA.PostProcess.exe
  OpenRA.Game -> /Users/paul/src/Open RA/OpenRA.Game.exe
  /var/folders/gm/2m3hrbv5637f4dhttxn62s1w0000gn/T/tmpf0d03cb3bde64fc3a1069c59af5e1785.exec.cmd: line 2: /Users/paul/src/Open: No such file or directory
/Users/paul/src/Open RA/OpenRA.Game/OpenRA.Game.csproj(79,5): error MSB3073: The command "/Users/paul/src/Open RA/OpenRA.PostProcess.exe /Users/paul/src/Open RA/OpenRA.Game.exe -LAA" exited with code 127.

This PR (fails with unexpected error):

paul@Ragnarok:Open RA+pr/16718$ make
  OpenRA.PostProcess -> /Users/paul/src/Open RA/OpenRA.PostProcess.exe
  OpenRA.Game -> /Users/paul/src/Open RA/OpenRA.Game.exe
  /var/folders/gm/2m3hrbv5637f4dhttxn62s1w0000gn/T/tmpd6a16d00f0ef4f5ab05f439012066080.exec.cmd: line 2: /Users/paul/src/Open RA/OpenRA.PostProcess.exe: Permission denied
/Users/paul/src/Open RA/OpenRA.Game/OpenRA.Game.csproj(79,5): error MSB3073: The command ""/Users/paul/src/Open RA/OpenRA.PostProcess.exe" "/Users/paul/src/Open RA/OpenRA.Game.exe" -LAA" exited with code 126.
@pchote

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

The magic quotes appear to be breaking the magic mono detection...

Adding mono to the command (<Exec Command="mono &quot;$(TargetDir)OpenRA.PostProcess.exe&quot; &quot;$(TargetPath)&quot; -LAA" />) fixes things, but will obviously break things on Windows.

We may have to implement OS-specific branches here, eww.

@pchote

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

1fbbbfb fixes this to work on macOS/Linux/Windows.

@RoosterDragon RoosterDragon force-pushed the RoosterDragon:fix-postprocess branch from 5182080 to 53e7b11 Jun 23, 2019

@pchote
pchote approved these changes Jun 23, 2019

@pchote pchote added the PR: Needs +2 label Jun 23, 2019

@abcdefg30 abcdefg30 merged commit 8f57356 into OpenRA:bleed Jun 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@RoosterDragon RoosterDragon deleted the RoosterDragon:fix-postprocess branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.