Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crate regressions #16720

Merged
merged 3 commits into from Jun 22, 2019

Conversation

@pchote
Copy link
Member

commented Jun 21, 2019

Fixes #16661
Fixes #16717
Also fixes water crates not spawning, a regression from way back in #6748!

@pchote pchote added this to the Next Release milestone Jun 21, 2019

@teinarss
Copy link
Contributor

left a comment

Works as intended and code looks fine

@MustaphaTR
Copy link
Member

left a comment

Tested crates both in RA and CnC and seem to work fine. Crates can spawn in water in RA.

@MustaphaTR MustaphaTR merged commit 71ed22a into OpenRA:bleed Jun 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MustaphaTR

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

@pchote pchote deleted the pchote:fix-crate-regressions branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.