Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Fake Allied Barracks #16734

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@Punsho
Copy link
Contributor

commented Jun 29, 2019

A long requested feature that is largely agreed upon

Cameo was taken from SoScared's "Unplugged" mod

mods/ra/rules/fakes.yaml Outdated Show resolved Hide resolved
@MustaphaTR

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

At the point i feel like we should add fake refinery and helipad too and complete the set.

@Punsho Punsho force-pushed the Punsho:FakeTent branch from e2b9700 to ffd4695 Jun 30, 2019

@netnazgul

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

@MustaphaTR overloading France's defence tab should be considered here. Fake tent is quite a requested feature to deny though.

@Orb370

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2019

rattle rattle

Long requested feature. If overloading the defense tab is an issue (though we have space for 1 more structure), we could easily remove f. naval yard/f. adv power plant. Also there's a fake subpen for some reason? (In debug)

000693

@MustaphaTR

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

Fake Subpen is something original had for some reason too, which is why we have it. It was not buildable there either. I think fakes were meant to be availabe to both sides at some point, sine Shipyard/Subpen was the only side specific fake in the original, others were ConYard, WFac and Radar. If it is an issue i can be -Buildable:d instead of Prerequisite: ~disabled.

@pchote pchote added this to the Next Release milestone Jul 20, 2019

@pchote
Copy link
Member

left a comment

One request, otherwise LGTM

mods/ra/rules/fakes.yaml Outdated Show resolved Hide resolved

@Punsho Punsho force-pushed the Punsho:FakeTent branch from ffd4695 to 83522a5 Jul 20, 2019

@Punsho Punsho changed the title Adding Fake Tent Adding Fake Allied Barracks Jul 20, 2019

mods/ra/rules/fakes.yaml Outdated Show resolved Hide resolved
Punsho Punsho

@Punsho Punsho force-pushed the Punsho:FakeTent branch from 83522a5 to 41330c5 Jul 21, 2019

@pchote
pchote approved these changes Jul 21, 2019

@pchote pchote added the PR: Needs +2 label Jul 21, 2019

@reaperrr reaperrr merged commit 9ac3d75 into OpenRA:bleed Jul 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Punsho Punsho deleted the Punsho:FakeTent branch Jul 22, 2019

@Jehoel

This comment has been minimized.

Copy link

commented Aug 25, 2019

@netnazgul overloading France's defence tab should be considered here.

I'd like to see "groups" or horizontal dividers within each tab - which is handy when you have both Allied and Soviet tech-trees available - to keep Allied and Soviet-exclusive build buttons separate, for example, - it could also be used to separate Fake structures from real structures - or move Fake structures to their own separate construction tab?

Or have a single construction tab split into sub-groups? That would also make a better use of the increased screen real-estate on large modern displays.

(With apologies for being off-topic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.