Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary render scissor from ButtonWidget #16744

Merged

Conversation

@dragunoff
Copy link
Contributor

commented Jul 1, 2019

@pchote pchote added this to the Next Release milestone Jul 1, 2019

@dragunoff dragunoff force-pushed the dragunoff:fix/remove-render-scissor-button-widget branch from 6d764b3 to f13c721 Jul 2, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

Updated with @pchote's suggestion.

But there is something subtle going on here (or I'm missing something obvious) because sometimes the tooltip would stop appearing. I can't reliably reproduce that - it seems to be happening at random after some rebindings.

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 7, 2019

Problems with tooltips not showing when the UI changes underneath the mouse cursor are usually avoided by calling Ui.ResetTooltips() after changing the UI.

@dragunoff dragunoff force-pushed the dragunoff:fix/remove-render-scissor-button-widget branch from f13c721 to 29187ca Jul 8, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

This is now based on #16759

I tried adding Ui.ResetTooltips() to several places in SettingsLogic.cs but to no avail. The tooltip would stop appearing after a few remaps.

@teinarss

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Rebase needed!

@dragunoff dragunoff force-pushed the dragunoff:fix/remove-render-scissor-button-widget branch from 29187ca to 27e3520 Jul 19, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

Rebased.

@pchote pchote removed the PR: Rebase me! label Jul 19, 2019

@pchote
pchote approved these changes Jul 20, 2019
Copy link
Member

left a comment

LGTM. I filed #16812 to cover the other issues, which can be done in a separate PR.

@pchote pchote added the PR: Needs +2 label Jul 20, 2019

@abcdefg30 abcdefg30 merged commit 86c8dfe into OpenRA:bleed Jul 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jul 20, 2019

@dragunoff dragunoff deleted the dragunoff:fix/remove-render-scissor-button-widget branch Sep 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.