Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Selectable from planes in TD #16746

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@abcdefg30
Copy link
Member

commented Jul 1, 2019

Fixes the

OpenRA.Utility(1,1): Warning: Actor c17 defines both Interactable and Selectable traits. This may cause unexpected results.
OpenRA.Utility(1,1): Warning: Actor a10 defines both Interactable and Selectable traits. This may cause unexpected results.

warnings of make test accidentally introduced in #15839.

@abcdefg30 abcdefg30 added this to the Next Release milestone Jul 1, 2019

@teinarss
Copy link
Contributor

left a comment

LGTM

@dragunoff

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

Alternatively this can be fixed by -Selectable on the affected actors (C17 and A10).

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

C17 and A10 are the only ^Planes, so it makes more sense to do this on the default.

@pchote
pchote approved these changes Jul 1, 2019

@pchote pchote merged commit b35dfb5 into OpenRA:bleed Jul 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:interlectable branch Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.