Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location checks for queued deployment. #16748

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@tovl
Copy link
Contributor

commented Jul 1, 2019

Fixes #16600

Previously the check for bogus locations was effectively ignored.

@pchote pchote added this to the Next Release milestone Jul 1, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Needs a rebase now.

@tovl tovl force-pushed the tovl:deploy-check branch from 263de4c to ca4ad3a Jul 3, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

Rebased.

@pchote pchote removed the PR: Rebase me! label Jul 3, 2019

@@ -71,15 +68,10 @@ public override bool Tick(Actor self)
return false;

This comment has been minimized.

Copy link
@pchote

pchote Jul 3, 2019

Member

This can be return true now, right?

This comment has been minimized.

Copy link
@tovl

tovl Jul 3, 2019

Author Contributor

True 😛

But it doesn't matter either way. The childactivity will never finish so this will never actually proceed to the next activity.

@pchote
pchote approved these changes Jul 6, 2019

@pchote pchote merged commit 2912bff into OpenRA:bleed Jul 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.