Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flag in spec ui #16749

Merged
merged 2 commits into from Jul 21, 2019

Conversation

@teinarss
Copy link
Contributor

commented Jul 3, 2019

Closes #16736

@pchote pchote added this to the Next Release milestone Jul 3, 2019

@abcdefg30
Copy link
Member

left a comment

Works. But I'm not sure if moving the method is a good thing. Imho we also want to fix this for when a spectator views the menu.

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

When you press esc.

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Updated to fix score screen

@abcdefg30
Copy link
Member

left a comment

The bug in the menu still exists if you start as player and then surrender.

@teinarss teinarss force-pushed the teinarss:fix_16736 branch from 83ba9d7 to 65a2a53 Jul 4, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

Updated!

@pchote
Copy link
Member

left a comment

LGTM otherwise.

@teinarss teinarss force-pushed the teinarss:fix_16736 branch from 65a2a53 to c5f9e31 Jul 20, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2019

Updated!

@reaperrr reaperrr merged commit 60250e6 into OpenRA:bleed Jul 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.