Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection tiers as inheritable templates #16760

Merged
merged 1 commit into from Dec 8, 2019

Conversation

@dragunoff
Copy link
Contributor

dragunoff commented Jul 8, 2019

This is based on #16662 but includes rules for TS and incorporates the templates for selection modes (introduced in #15839) into the selection tiers.

Tier RA TD D2K TS
Combat Units ^Vehicle, ^Infantry, ^Ship, ^NeutralPlane ^Vehicle, ^Infantry, ^Ship, ^Helicopter, ^DINO, ^Viceroid ^Infantry, ^Vehicle ^Infantry, ^Vehicle, ^Aircraft, ^Visceroid, ^Train
Support Units MCV, MNLY, E6, MOBILETENT, TRUK MCV, E6, TRUK mcv, engineer ENGINEER, MCV, LPST, ICBM, ^TRUCK
Economic Units HARV HARV harvester HARV, WEED
Combat Buildings ^Defense ^Defense ^Defense ^Defense
Buildings ^BasicBuilding ^Building ^Building ^BasicBuilding

Closes #16555

@abcdefg30 abcdefg30 mentioned this pull request Jul 9, 2019
@dragunoff dragunoff mentioned this pull request Nov 22, 2019
@tovl

This comment has been minimized.

Copy link
Contributor

tovl commented Dec 4, 2019

We might want to add TRUCK and ICBM in Tiberian Sun to the support units list.

I also think that TRUK in the other mods might fit better as support unit than as economic unit, because—unlike harvesters—it does not have automated behaviour.

@dragunoff dragunoff force-pushed the dragunoff:feature/seleciton-tiers branch from 111cb7d to 82a6e97 Dec 7, 2019
@dragunoff

This comment has been minimized.

Copy link
Contributor Author

dragunoff commented Dec 7, 2019

Updated with tovl's suggestions.

@tovl
tovl approved these changes Dec 7, 2019
@tovl tovl added the PR: Needs +2 label Dec 7, 2019
@tovl tovl mentioned this pull request Dec 7, 2019
16 of 16 tasks complete
@tovl tovl added the PR: For stable label Dec 8, 2019
@reaperrr reaperrr merged commit 93e42b0 into OpenRA:bleed Dec 8, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dragunoff dragunoff deleted the dragunoff:feature/seleciton-tiers branch Dec 8, 2019
@dragunoff dragunoff restored the dragunoff:feature/seleciton-tiers branch Dec 8, 2019
@dragunoff dragunoff deleted the dragunoff:feature/seleciton-tiers branch Dec 8, 2019
@pchote pchote added this to the Next Release milestone Dec 15, 2019
@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 15, 2019

This pushes the envelope of what I would consider safe to go into a hotfix (which generally don't get playtests before a public release), so fingers crossed that this hasn't introduced any regressions.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Dec 23, 2019

I was assuming we'd publish at least one playtest in this particular case due to the number (and in a few cases size) of changes, but if you feel this change is too risky, I can revert it.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Dec 23, 2019

Probably best to put out a playtest (or at least a forum/irc/discord dev test) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.