Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception should inform which actors causes it. #16771

Merged
merged 1 commit into from Jul 27, 2019

Conversation

@IceReaper
Copy link
Contributor

commented Jul 13, 2019

A common encountered exception, which informs about a missing trait should name who is missing the trait, otherwise you keep blindly searching for it.

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 13, 2019

Can you please also change GetOrDefault to keep the method arguments consistent?

@IceReaper IceReaper force-pushed the IceReaper:better-exception branch from 3f36a8f to 9aa6fba Jul 13, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

TraitDictionary.cs(95,38): error CS1503: Argument 1: cannot convert from 'uint' to 'OpenRA.Actor' [C:\projects\openra\OpenRA.Game\OpenRA.Game.csproj]

@IceReaper IceReaper force-pushed the IceReaper:better-exception branch from 9aa6fba to ab52b4d Jul 13, 2019

@IceReaper

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

TraitDictionary.cs(95,38): error CS1503: Argument 1: cannot convert from 'uint' to 'OpenRA.Actor' [C:\projects\openra\OpenRA.Game\OpenRA.Game.csproj]

Yeah i got interrupted in the middle of adding files, noticed myself, added the missing file already.

@IceReaper IceReaper force-pushed the IceReaper:better-exception branch from ab52b4d to c6d3222 Jul 13, 2019

@reaperrr reaperrr added this to the Next Release milestone Jul 26, 2019

@pchote
pchote approved these changes Jul 27, 2019

@pchote pchote merged commit ebc533e into OpenRA:bleed Jul 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.