Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix harvesters losing their last harvesting position when carried by carryall. #16778
Testing this shows another fairly bad regression with carryalls:
Things get weird, depending on the exact timing. The most common case is that the carryall will deliver the harvester to the first location, even though it was cancelled well before the harvester was actually picked up. I had one time where the carryall was locked in a single facing directly above the harvester, sliding around the map while the harvester kept driving (it picked it up and delivered it to the wrong place when the harvester was stopped). Another time had the carryall pick up the harvester sideways.
The harvester sliding behind the harvester seems to be the
It is clear though that the root cause is that the carryall should not be messing with the activity queues at all, so I decided to just implement #16721 (comment) right now and get rid of all that.
The problem of the carryall delivering the harvester to the first location despite a new order being given seems to not be an actual regression but an old bug. This is fixed by introducing a new parent activity which can pass the destination to