Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several traits missing OrderString checks for VoicePhraseForOrder #16783

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Jul 16, 2019

Fixes #16773

@abcdefg30
Copy link
Member

left a comment

Looks good.

@pchote pchote added this to the Next Release milestone Jul 16, 2019

@pchote
pchote approved these changes Jul 16, 2019
Copy link
Member

left a comment

The MAD tank is completely broken (doesn't move out of the war factory) in the PR as submitted. This is based on quite an old bleed commit, and whatever caused this seems to have since been fixed.

Code changes look correct, and this behaves as expected when rebased on latest bleed so 👍

Please do test your PRs before filing them, though.

@pchote pchote merged commit 30e2b69 into OpenRA:bleed Jul 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:voice-order-name-check branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.