Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ReturnToBase to exit if actor does not land at building. #16787

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@tovl
Copy link
Contributor

commented Jul 16, 2019

Fixes a small oversight in #16481.

@pchote pchote added this to the Next Release milestone Jul 16, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Does this fix #16784?

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Not quite. It partially fixes the first part of that issue. Helis will only hover above the repair bay but will not in anyway occupy it or repair when fired upon.

@fruestueck

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Not quite. It partially fixes the first part of that issue. Helis will only hover above the repair bay but will not in anyway occupy it or repair when fired upon.

Should i split the issue? Thought they are alsmost the same

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

No need. This is a fix for a minor unreported issue that is only tangentially related to that issue.

@pchote
pchote approved these changes Jul 18, 2019
Copy link
Member

left a comment

This fixes helicopters that are ordered to RTB with full ammo from flying to the helipad and then continuously queuing Fly children to their current position. They will now fly to the helipad and go idle.

@pchote pchote added the PR: Needs +2 label Jul 18, 2019

@abcdefg30 abcdefg30 merged commit a38c2d9 into OpenRA:bleed Jul 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.