Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GrantConditionOnAttack PausableConditional #16793

Merged
merged 1 commit into from Jan 26, 2020

Conversation

@MustaphaTR
Copy link
Member

MustaphaTR commented Jul 17, 2019

Disabling it revokes the condition and makes it not possible to be granted while it is disabled.

Pausing just makes it impossible to grant. Existing conditions will be revoked by timer.

Testcase makes it so Light Tank gets gatling like weapon system changing between 1TNK, 2TNK and 3TNK weapons. Normally takes 8 shots to go up, but when elite it takes 4.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jul 17, 2019

What is the benefit of this vs writing an expression that combines the output of GrantConditionOnAttack with the condition that would disable/pause it?

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Jul 17, 2019

Why i need is for is pretty much the testcase. When elite Gatling Tank moves thru the levels faster.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:conditional-gcoa branch from de7508c to 65d9b17 Jul 17, 2019
@GraionDilach

This comment has been minimized.

Copy link
Contributor

GraionDilach commented Jul 17, 2019

Different name between promoted and unpromoted weapon with GCOA tracking per-armament names/additional dummy weapons enabled with veterancy... I can think of ways to set this up already.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Jul 17, 2019

I guess Graion is right, tho i don't see any reason for not making the trait conditional.

@reaperrr reaperrr mentioned this pull request Nov 17, 2019
Copy link
Member

Mailaender left a comment

Code looks fine.

Copy link
Member

pchote left a comment

Noticed one obvious code issue, and can you please rebase this on current bleed to allow proper testing?

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:conditional-gcoa branch from 65d9b17 to c8b77b6 Jan 16, 2020
@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Jan 16, 2020

Updated and rebased.

@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 25, 2020

Testcase needs to be removed.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:conditional-gcoa branch from c8b77b6 to 0e5f691 Jan 25, 2020
@MustaphaTR

This comment has been minimized.

Copy link
Member Author

MustaphaTR commented Jan 25, 2020

Removed testcase.

@abcdefg30 abcdefg30 merged commit d7f43b3 into OpenRA:bleed Jan 26, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 26, 2020

@MustaphaTR MustaphaTR deleted the MustaphaTR:conditional-gcoa branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.