Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix player color when a client is bumped to a spectator slot. #16828

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@pchote
Copy link
Member

commented Jul 22, 2019

Fixes a polish issue reported on Discord.

Testcase:

  • Select a map with N > 2 players
  • Move to the last player slot
  • Fill the rest of the slots with bots
  • Change to a map with less players

The spectator's color is now correctly reset.

@pchote pchote added this to the Next Release milestone Jul 22, 2019

@teinarss
Copy link
Contributor

left a comment

LGTM

@abcdefg30 abcdefg30 merged commit c00b13a into OpenRA:bleed Jul 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@pchote pchote deleted the pchote:fix-spectator-color branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.