Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tick performance regression #16846

Merged
merged 2 commits into from Jul 27, 2019

Conversation

@pchote
Copy link
Member

commented Jul 27, 2019

The first commit adds a new line to the perf graph (hide whitespace changes to see that it is effectively a one-line addition).

The second commit fixes the silly oversight that was eating all of our Tick performance - CellsUpdated was being called for every cell that ever changed, not just the ones that changed this tick.

@pchote pchote added this to the Next Release milestone Jul 27, 2019

@pchote pchote requested review from teinarss and reaperrr Jul 27, 2019

@pchote pchote referenced this pull request Jul 27, 2019
@reaperrr
Copy link
Contributor

left a comment

Code changes are simple enough and perf is back to (at least) pre #16698 levels

@teinarss
Copy link
Contributor

left a comment

Looks good

@reaperrr reaperrr merged commit 2f99512 into OpenRA:bleed Jul 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-tick-perf branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.