Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allies05a crashing #16859

Merged
merged 4 commits into from Aug 10, 2019

Conversation

@abcdefg30
Copy link
Member

commented Jul 28, 2019

Fixes #16855.

Testcase was infiltrating the prison without infiltrating the warfactory. This should make the script more robust against all sorts of weird things that can happen when infiltrating the prison first. Also makes warfactory infiltration a secondary objective which isn't strictly necessary but works better imho. (E.g. if you somehow managed to get the truck killed you can still win, just not by infiltrating the warfactory.)

@reaperrr reaperrr added this to the Next Release milestone Jul 28, 2019

@pchote
Copy link
Member

left a comment

👍 to the changes here, but something is really broken for dogs to not detect spies at a range of 2 cells...

mods/ra/maps/allies-05a/allies05a.lua Outdated Show resolved Hide resolved
mods/ra/maps/allies-05a/allies05a.lua Outdated Show resolved Hide resolved

@pchote pchote added the PR: Needs +2 label Aug 6, 2019

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

+1 to the changes here, but something is really broken for dogs to not detect spies at a range of 2 cells...

This is because the dog needs a certain time to aim before it actually attacks. During this time, the spy can get out of range and the dog drops the target. Setting DogJaw's range to 2c256 (for example) fixes this, as the dog will aim earlier and be able to attack while the target is in range.

@matjaeck
Copy link
Contributor

left a comment

LGTM otherwise.

@abcdefg30 abcdefg30 dismissed stale reviews from matjaeck and pchote via ebcaacf Aug 7, 2019

@abcdefg30 abcdefg30 force-pushed the abcdefg30:cam05a branch from 1d97c5f to ebcaacf Aug 7, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

Rebased and updated.

@pchote
pchote approved these changes Aug 10, 2019

@pchote pchote merged commit 859d01d into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:cam05a branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.