Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore target line display for allied players and spectators. #16876

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@pchote
Copy link
Member

commented Aug 5, 2019

Fixes a regression from #16549. IMO the pre-16549 behavior always felt unpolished (target lines popping out of nowhere without viewer action), so I have brought this back with a major tweak: the lines are now only visible when the queue-modifier (now shift) is held.

Restore target line display for allied players and spectators.
Change behaviour to require the force-display modifier to reduce
visual noise.

@pchote pchote added this to the Next Release milestone Aug 5, 2019

@matjaeck
Copy link
Contributor

left a comment

Works.

@abcdefg30 abcdefg30 merged commit 96263d4 into OpenRA:bleed Aug 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@pchote pchote deleted the pchote:spectator-target-lines branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.