Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse target line draw order. #16879

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@pchote
Copy link
Member

commented Aug 5, 2019

This implements a minor polish fix for the target lines.

Before:

After:

My implementation doesn't feel very elegant, but a cleaner solution wasn't obvious to my flight-addled brain. Suggestions welcome!

@pchote pchote added this to the Next Release milestone Aug 5, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

This implements a minor polish fix for the target lines.

Before:

After:

My implementation doesn't feel very elegant, but a cleaner solution wasn't obvious to my flight-addled brain. Suggestions welcome!

Dont think its worth to try finding a cleaner solution! :P

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

Needs a rebase, though.

@pchote pchote force-pushed the pchote:target-marker-polish branch from 5e71960 to 6f2df34 Aug 6, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Rebased.

@pchote pchote removed the PR: Rebase me! label Aug 6, 2019

@abcdefg30 abcdefg30 merged commit 1543ccb into OpenRA:bleed Aug 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

@pchote pchote deleted the pchote:target-marker-polish branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.