Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define nearenough parameter for aircraft #16897

Merged
merged 1 commit into from Aug 23, 2019

Conversation

@tovl
Copy link
Contributor

commented Aug 7, 2019

Introduces a nearEnough parameter for the Fly activity similar to the one in Move. This allows aircraft to exit early when they get stuck during their movement and prevents queued aircraft orders from never being executed.

It doesn't really solve the jostling for position problem, but at least lets the aircraft snap out of it after a while.

Fixes #11521
Split from #16883

@pchote pchote added this to the Next Release milestone Aug 7, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Adding to the milestone as discussed in IRC.

@tovl tovl force-pushed the tovl:air-nearenough branch from 478dc1f to 27c4c2c Aug 7, 2019

OpenRA.Mods.Common/Activities/Air/Fly.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/AttackMove.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Activities/Air/Fly.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Air/Aircraft.cs Outdated Show resolved Hide resolved

@tovl tovl force-pushed the tovl:air-nearenough branch 2 times, most recently from e88d36a to ae9301e Aug 10, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Updated

@tovl tovl force-pushed the tovl:air-nearenough branch from ae9301e to 8bf9e59 Aug 17, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Testing this some more, I'm not seeing any significant difference between this and bleed wrt #11521. I spent some more time trying to find workarounds at the repulsion side, but couldn't find anything that worked better than my previous idea.

IMO we've given this a good try, but have now passed the point of throwing good time after bad. We should defer this for #16883 to fix properly in Next + 1.

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

One last attempt: d422236

This matches against the specific thing we want to avoid ("have we moved by less than a pixel in the last short while"), and IMO feels pretty good ingame even if the code is a bodge.

I'll put this in my next test build to get some wider feedback.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Testing this some more, I'm not seeing any significant difference between this and bleed wrt #11521.

Apparently the behaviour is not the same between ae9301e and 8bf9e59. I don't know why.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

One last attempt: d422236

I'm not sure what's going on here, but that seems to go about as bad as 8bf9e59 for me.

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

@tovl tovl force-pushed the tovl:air-nearenough branch from 8bf9e59 to be3a006 Aug 18, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

OK. Got it working now. Updated.

@pchote
pchote approved these changes Aug 18, 2019

@pchote pchote added the PR: Needs +2 label Aug 18, 2019

@reaperrr reaperrr merged commit ed8abe9 into OpenRA:bleed Aug 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.