Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing target lines. #16903

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@tovl
Copy link
Contributor

commented Aug 8, 2019

Fixes #16884
Fixes #16898

@pchote pchote added this to the Next Release milestone Aug 8, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

There are several other places where AttackMove is queued without defining a target line: ProductionParadrop, TakeOff, Hunt, and the Lua APIs for queueing attack move / hunt.

@tovl tovl force-pushed the tovl:add-missing-lines branch from 5303a3f to fde6a66 Aug 8, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Added the lines for TakeOff and ProductionParadrop. I'm not sure it makes much sense to show target lines for scripted actions or Hunt since these are never directly controlled by the player. Showing the randomly appearing one-cell lines for hunting creeps just looks weird.

@matjaeck
Copy link
Contributor

left a comment

The target lines are fixed for RTB orders and for ground and naval units that leave their production facility (including ProductionAirdrop). I noticed that unarmed units also show a red a-move target line although you can't order them to a-move, just as a side note.

For planes and helicopters, no target lines are displayed when they take off and approach the rally point.

I don't know how to test ProductionParadrop.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

For planes and helicopters, no target lines are displayed when they take off and approach the rally point.

That seems like a logical consequence of #16912 rather than a problem with the target lines themselves.

I noticed that unarmed units also show a red a-move target line although you can't order them to a-move, just as a side note.

That is indeed a bit odd, but I don't know what would be correct in this case. They are given AttackMove orders like all other units, but without a valid attack this is functionally equivalent to a normal Move. Does this need to be addressed here?

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

That seems like a logical consequence of #16912 rather than a problem with the target lines themselves.

Note that this issue only applies to airfields, not to helipads (but helicopters also miss target lines when approaching the rally point).

Edit: FWIW I don't think the red target lines for unarmed units need to be fixed (here).

@tovl tovl force-pushed the tovl:add-missing-lines branch from fde6a66 to f921cfc Aug 9, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

Updated with fix for helicopters.

@matjaeck
Copy link
Contributor

left a comment

LGTM.

@abcdefg30 abcdefg30 merged commit c0d5cd7 into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.