Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow Attack Move and Guard OGs to be activated while shift is held. #16908
This PR generalizes the fix from #15596 to also work for Attack Move and Guard.
In the future (it is well out of scope for this PR) we should consider expanding the hotkey system and UI to prevent players from rebinding these commands against Shift, which would prevent them from ever working.
matjaeck left a comment •
This works well and is definitely an improvement.
For people who use the hotkey instead of the command bar it would be nice to allow deactivating the order generator with the hotkey without losing the selection, as described in #16381 (comment).
Since this closes the issue, I'm wondering whether I should open a new issue specifically for this request.
Edit: I think, after this PR, #13390 is fixed.
matjaeck left a comment
Can someone confirm that the last change regressed activating attack-move while shift is held? It still works for guard, but not for attack-move on my end (even when I reset the head back to the first commit). Deactivating with left mouse click is even better than with the hotkey, so I'm hoping this is a trivial error on my end or a bug that can be fixed.