Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when unloading Cargo structures #16915

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@teinarss
Copy link
Contributor

commented Aug 9, 2019

Fixes #16914

@teinarss teinarss added this to the Next Release milestone Aug 9, 2019

@matjaeck
Copy link
Contributor

left a comment

Bug and fix confirmed. Approving after somebody confirms that this an expected change.

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Minor nit: Can you please fix "pileboxes" → "pillboxes", or even better → "Cargo structures" in the commit message?

@teinarss teinarss changed the title Prevent crash when unloading pileboxes Prevent crash when unloading Cargo structures Aug 10, 2019

@teinarss teinarss force-pushed the teinarss:fix_pilebox_unload branch from b30ca87 to abda2de Aug 10, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Updated

@abcdefg30 abcdefg30 merged commit daa82d1 into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

Seems like #16509 doesn't have a changelog, so skipping here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.