Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preemptive targeting for queued orders. #16918

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@tovl
Copy link
Contributor

commented Aug 9, 2019

Fixes #16911

@pchote pchote added this to the Next Release milestone Aug 9, 2019

@matjaeck
Copy link
Contributor

left a comment

Can't find any issues here.

@Punsho

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

I dunno if it should be written as a separate issue but aircraft can attack only one target per flyby. It is a huge regression as you can no longer properly utilise shift-attack

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Is this a regression in this PR or already on bleed?

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

I dunno if it should be written as a separate issue but aircraft can attack only one target per flyby. It is a huge regression as you can no longer properly utilise shift-attack

Is this a regression in this PR or already on bleed?

Already present on bleed, but only visible under the right conditions. Do we want a new issue for this?

I have documented the behavior on bleed / PR / last release below:

292196e

2 queued attack targets from idle state

  • yak attacks the last queued target
  • yak idles after destroying one target
    queuefromidle

2 queued attack targets from non-idle state

  • yak attacks the first queued target
  • yak can not switch to next target in same flyby
  • yak returns to attack next target
    queuedfromnonidle
This PR The behavior in both cases is the same.
  • yak can not switch to next target in same flyby

2 queued attack targets from idle state

queuefromidle_pr

2 queued attack targets from non-idle state

queuedfromnonidle_pr

Release-20190314 The behavior in both cases is the same.
  • yak can switch to next target in same flyby

2 queued attack targets from idle state

queuefromidle_r

2 queued attack targets from non-idle state

queuedfromnonidle_r

@tovl tovl force-pushed the tovl:queue-attackfollow branch from ce81641 to 43ac1c8 Aug 10, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Updated.

@matjaeck
Copy link
Contributor

left a comment

Fixes #16911, opened #16922 for the flyby issue.

@pchote
pchote approved these changes Aug 10, 2019

@pchote pchote merged commit 5393b68 into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.