Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust waypoint linewidths. #16921

Merged
merged 1 commit into from Aug 10, 2019

Conversation

@tovl
Copy link
Contributor

commented Aug 10, 2019

  • Reduces all target lines in gen1 mods to 1 pixel width
  • In gen2 mods active lines are now 1 pixel width and queued waypoints are 2 pixel width (similar to RA2 waypoint mode)

(hopefully) closes #16616

@pchote pchote added this to the Next Release milestone Aug 10, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Aug 10, 2019

In gen2 mods active lines are now 1 pixel width and queued waypoints are 2 pixel width (similar to RA2 waypoint mode)

Wouldn't it make more sense to have the active line at 2px then queued at 1? The active one is more important, after all.

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

Wouldn't it make more sense to have the active line at 2px then queued at 1? The active one is more important, after all.

The active lines appear on every order when the automatic drawing setting is activated, so the 2px width only for queued orders seems less obtrusive.

Edit: I haven't tested it in gen2 mods so can't really say if it is obtrusive.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

When selecting a group of units the active lines are drawn from each individual unit towards the first waypoint. Each subsequent waypoint effectively gets only one target line from the last waypoint to the next. This means that the issue of target lines obscuring the units only really applies to the active lines. It also makes for a good visual if multiple thinner lines converge into a slightly thicker line, because it emphasizes the direction of the target lines. I suspect these were the same considerations that went into the waypoint lines in RA2.

@tovl tovl force-pushed the tovl:linewidth branch from 945ff52 to 2d430ff Aug 10, 2019

@tovl tovl force-pushed the tovl:linewidth branch from 2d430ff to fb5105c Aug 10, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Aug 10, 2019

Updated so markers in gen2 mods also change sizes depending on queued status (like in RA2).

@pchote
pchote approved these changes Aug 10, 2019

@pchote pchote merged commit a8b9562 into OpenRA:bleed Aug 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.