Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow single observers to use spectator team chat in mp #16949

Merged
merged 1 commit into from Aug 19, 2019
Merged

Allow single observers to use spectator team chat in mp #16949

merged 1 commit into from Aug 19, 2019

Conversation

abcdefg30
Copy link
Member

Apparently this "feature" is high in demand for teaching purposes, so adding it back. It makes the code simpler, too.

@abcdefg30 abcdefg30 added this to the Next Release milestone Aug 16, 2019
pchote
pchote approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks sensible, but not tested ingame.

@teinarss teinarss merged commit 8cf6aa2 into OpenRA:bleed Aug 19, 2019
@teinarss
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/673f3ddf3588a3ca429c9e98368bb4e0a825bdba...3100819edc5f1c63f6f63520f8ef49601a91c20e

@abcdefg30 abcdefg30 deleted the teamOne branch August 19, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@teinarss teinarss teinarss approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20191117 / 20200202
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abcdefg30 @teinarss @pchote