Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells with Temporary blockers should not exit early in locomotor cache #16957

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@teinarss
Copy link
Contributor

commented Aug 18, 2019

Fixes #16863

@pchote pchote added this to the Next Release milestone Aug 18, 2019

@tovl
Copy link
Contributor

left a comment

Fix confirmed.

@@ -279,7 +279,7 @@ public bool CanMoveFreelyInto(Actor actor, CPos cell, Actor ignoreActor, CellCon
return true;

// Cache doesn't account for ignored actors - these must use the slow path

This comment has been minimized.

Copy link
@abcdefg30

abcdefg30 Aug 18, 2019

Member

Imho the comment should be updated with a reference to temporary blockers, like Cache doesn't account for ignored actors or temporary blockers - these must use the slow path.

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Fix works.

@teinarss teinarss force-pushed the teinarss:fix_temp_blockers branch from a6f9424 to 52db21a Aug 19, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Updated

@abcdefg30 abcdefg30 merged commit 7544d4b into OpenRA:bleed Aug 19, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.