Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RA Shellmap infantry triggers #16964

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@pchote
Copy link
Member

commented Aug 19, 2019

Fixes #16960 (both parts).

Supersedes #16963.

@pchote pchote added this to the Next Release milestone Aug 19, 2019

@tovl
tovl approved these changes Aug 20, 2019
Copy link
Contributor

left a comment

Looks good 👍

Just wondering though: Why didn't you deprecate the return unit list from SendParatroopers?

@pchote

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

Too big of a scope creep, so better handled in its own PR (which I plan to file soon). We need to be able to return the planes so scripts can bind OnPassengerExited, which means defining a new API. We then need to port over the existing maps.

@pchote pchote added the PR: Needs +2 label Aug 20, 2019

@abcdefg30 abcdefg30 merged commit a491bae into OpenRA:bleed Aug 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@pchote pchote deleted the pchote:fix-shellmap-triggers branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.