Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Paratroopers Lua API #16971

Merged
merged 3 commits into from Feb 29, 2020
Merged

Overhaul Paratroopers Lua API #16971

merged 3 commits into from Feb 29, 2020

Conversation

@pchote
Copy link
Member

pchote commented Aug 22, 2019

This pr deprecates SendParatroopers and SendParatroopersFrom, replacing both with a new ActivateParatroopers (named for consistency with the Ion Cannon and Nuke APIs) method.

The long deprecated *Upgrade methods are also removed.

Ideally we would merge this in time for the playtest to maximize the amount of time that mappers have to adjust their scripts and minimize the amount of time that we have to live with the legacy code - but I am not optimistic this is feasible, considering how long it takes every mission related PR to be reviewed.

I have tested some but nowhere near all of the Lua changes.

@pchote pchote force-pushed the pchote:paratroopers-lua-api branch from 837751f to 41c3127 Dec 1, 2019
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Dec 1, 2019

Fixed and rebased.

pchote added 2 commits Aug 21, 2019
SendParatroopers and SendParatroopersFrom are now deprecated.
The paratrooper actors themselves can be accessed using the
Trigger.OnPassengerExited trigger.
@pchote pchote force-pushed the pchote:paratroopers-lua-api branch from 41c3127 to 2eee790 Feb 27, 2020
@pchote pchote force-pushed the pchote:paratroopers-lua-api branch from 2eee790 to c3562f0 Feb 27, 2020
@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Feb 27, 2020

Rebased (first push) and fixed (second).

@Mailaender Mailaender merged commit d73ed76 into OpenRA:bleed Feb 29, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Mailaender

This comment has been minimized.

Copy link
Member

Mailaender commented Feb 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.