Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map Climax to the RA official map pool. #16990

Merged
merged 1 commit into from Sep 15, 2019

Conversation

@SoScared
Copy link
Member

commented Aug 25, 2019

Adding Climax (2v2) to the official map pool. Seem like a popular request, following #16865

Updated with the latest Playtest (map preview): https://resource.openra.net/maps/32473

32278

@SoScared

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

Testing map: Climax
OpenRA.Utility(1,1): Error: Actor Actor431 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor441 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor442 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor443 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor470 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor472 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor473 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor485 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor496 owner Creeps is not one of ValidOwnerNames: Neutral
OpenRA.Utility(1,1): Error: Actor Actor504 owner Creeps is not one of ValidOwnerNames: Neutral

Looks like some actors that should have 'Neutral' owner are owned by 'Creeps' instead (probably some trees). This needs to be fixed to fix the Travis error and to prevent AI from targeting them.

@SoScared

This comment has been minimized.

Copy link
Member Author

commented Aug 25, 2019

Fixed!

Copy link
Contributor

left a comment

There are still some cutted cliffs in here.
51,39 has been fixed with the wrong endcliff
Tile 155 can be set at 51, 38 and the cliff at the left is cutted now too ( Tile 154 )
The right endtile at 117,70 is tile 149
1,124 missed cliff
and 4,124 cutted cliff ( tile 144 )
81,57 can be replaced with tile 149

@wippie-openra

This comment has been minimized.

Copy link

commented Sep 7, 2019

@airetaM ; Thank you for taking the time to review this.
I performed rework on the areas mentioned. Also performed some visual updates on the map involving rockwork. Redrew them from scratch so I was absolutely sure to pick the right tiles.

Please find the update at here .

@SoScared how did you manage to do the updated map preview?

Copy link
Contributor

left a comment

Well done all broken cliffs are fixed now looking good for going official i would say.

@SoScared

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2019

@wippie-openra Just open and save your map with the playtest editor. It'll generate the new map preview.

@SoScared SoScared force-pushed the SoScared:map-climax branch from f8cd55d to 4117f19 Sep 9, 2019
@SoScared

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

Updated the PR with the latest map revision (including map preview update): https://resource.openra.net/maps/32626/

Copy link

left a comment

Review was done above by airetaM. File was checked in by SoScared afterwards

@abcdefg30 abcdefg30 merged commit 61aaac8 into OpenRA:bleed Sep 15, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Changelog

Added to prep since this has no regression risk: 46425ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.