Render via an intermediate framebuffer #16996

pchote · 2019-08-26T17:47:10Z

This PR kicks off the next set of renderer changes, which I'm hoping to complete during the Next + 1 cycle. This sets up a frame buffer to render everything into, which is then displayed as a quad over the game window. The screenshot code has been rewritten (removing the legacy GL2-only code) to fetch the texture data from the frame buffer.

This sets the foundation for two sets of future PRs:

Adding additional framebuffers for the world and world overlays (target lines, selection boxes), and using these to solve Arbitrary zoom / custom resolution support #10382, Cash ticks not desaturating in Shell map #6734, Chrono vortex #9778, [TS] Some Tiberium is rendered wrong #12876, etc.
Porting to GL 3.2 and removing our GL2 hacks and workarounds.

OpenRA.Game/Renderer.cs

OpenRA.Platforms.Default/ThreadedGraphicsContext.cs

pchote · 2019-08-27T09:39:43Z

This is going to need a fairly significant rework to behave properly wrt HiDPI - hold off reviewing until this is fixed.

pchote · 2019-08-27T23:45:37Z

Updated.

pchote · 2019-08-27T23:59:03Z

OpenRA.Game/Graphics/SpriteRenderer.cs

 				-depthScale * zoom / screen.Height);
-			shader.SetVec("r2", -1, 1, 1 - depthOffset);
+			shader.SetVec("r2", -1, -1, 1 - depthOffset);


Before anyone asks: this change and the EnableScissor rename are removing the hardcoded y coordinate flip that used to be baked in to the rendering to work around OpenGL's origin being the bottom left of the window. We now preserve coordinates through the frame buffer(s) and do the flip at the end by rendering the screen quad upside down.

OpenRA.Game/Renderer.cs

pchote · 2019-08-28T08:22:17Z

Fixed + fixed another issue that caused the framebuffer to be recreated each frame.

teinarss

Also getting these artifacts on my Dell xps 15, runnig with DisableWindowsDPIScaling: False
Windows 10 64bits.

OpenRA.Game/Renderer.cs

pchote · 2019-08-28T17:06:28Z

Fixed.

OpenRA.Game/Renderer.cs

pchote · 2019-08-31T09:13:17Z

Fixed.

teinarss

Looks good, cant comment on the opengl details. Tested on the same systems as before. no regression what i could detect.

OpenRA.Game/Renderer.cs

OpenRA.Game/Game.cs

chrisforbes · 2019-08-31T17:04:38Z

OpenRA.Game/Graphics/SpriteRenderer.cs

 				-depthScale * zoom / screen.Height);
-			shader.SetVec("r2", -1, 1, 1 - depthOffset);
+			shader.SetVec("r2", -1, -1, 1 - depthOffset);


chrisforbes · 2019-08-31T17:05:41Z

OpenRA.Game/Renderer.cs

+			// Render the compositor buffer to the screen
+			// HACK / PERF: Fudge the coordinates to cover the actual window while keeping the buffer viewport parameters
+			// This saves us two redundant (and expensive) SetViewportParams each frame
+			RgbaSpriteRenderer.DrawSprite(screenSprite, new float3(0, lastBufferSize.Height, 0), new float3(lastBufferSize.Width, -lastBufferSize.Height, 0));


You could use BlitFramebuffer here to avoid the viewport nonsense

glBlitNamedFramebuffer doesn't seem to be available from EXT_framebuffer_object, so this will have to wait until/after #17010

teinarss · 2019-09-01T10:50:29Z

Still looks good, tested after the updates.

pchote · 2019-09-03T21:57:49Z

I have several more PRs now being squeezed between this and my next overseas travel. Can we please prioritize getting this merged ASAP before my momentum screeches to a complete halt?

Not sure why this is still here.

teinarss · 2019-09-04T18:23:38Z

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/b7e62c0e71c3e77a5c96c98a67da61ec4f5ad6ba...ac3ed349d44a8efa90b52ec900afcad167573063

pchote requested a review from chrisforbes August 26, 2019 17:47

pchote force-pushed the renderer-framebuffer branch from f538925 to d7b3fdd Compare August 26, 2019 17:53

teinarss requested changes Aug 26, 2019

View reviewed changes

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

OpenRA.Platforms.Default/ThreadedGraphicsContext.cs Outdated Show resolved Hide resolved

pchote added PR: Fixup requested PR: Changes requested and removed PR: Fixup requested labels Aug 26, 2019

pchote force-pushed the renderer-framebuffer branch from d7b3fdd to 14caf0f Compare August 27, 2019 23:39

pchote removed the PR: Changes requested label Aug 27, 2019

pchote force-pushed the renderer-framebuffer branch from 14caf0f to 62abc76 Compare August 27, 2019 23:55

pchote commented Aug 27, 2019

View reviewed changes

pchote force-pushed the renderer-framebuffer branch from 62abc76 to a5612d7 Compare August 28, 2019 00:48

teinarss reviewed Aug 28, 2019

View reviewed changes

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

pchote force-pushed the renderer-framebuffer branch 2 times, most recently from 8327a3a to 95b79ee Compare August 28, 2019 08:21

teinarss requested changes Aug 28, 2019

View reviewed changes

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

teinarss added the PR: Fixup requested label Aug 28, 2019

pchote force-pushed the renderer-framebuffer branch from 95b79ee to af11e64 Compare August 28, 2019 16:40

pchote removed the PR: Fixup requested label Aug 28, 2019

teinarss previously approved these changes Aug 29, 2019

View reviewed changes

teinarss added the PR: Needs +2 label Aug 29, 2019

pchote added the PR: Has dependencies label Aug 29, 2019

pchote mentioned this pull request Aug 29, 2019

Migrate rendering to OpenGL 3.2 / OpenGL ES 3.0. #17010

Merged

pchote added PR: Is Dependency and removed PR: Has dependencies labels Aug 29, 2019

pchote commented Aug 30, 2019

View reviewed changes

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

OpenRA.Game/Renderer.cs Outdated Show resolved Hide resolved

pchote added the PR: Fixup requested label Aug 30, 2019

pchote dismissed teinarss’s stale review via 013e7bc August 31, 2019 08:44

pchote force-pushed the renderer-framebuffer branch from af11e64 to 013e7bc Compare August 31, 2019 08:44

pchote removed the PR: Fixup requested label Aug 31, 2019

pchote requested a review from teinarss August 31, 2019 09:13

teinarss previously approved these changes Aug 31, 2019

View reviewed changes

RoosterDragon previously requested changes Aug 31, 2019

View reviewed changes

OpenRA.Game/Renderer.cs Show resolved Hide resolved

RoosterDragon added the PR: Changes requested label Aug 31, 2019

chrisforbes reviewed Aug 31, 2019

View reviewed changes

pchote added 2 commits August 31, 2019 18:38

Render voxels before BeginFrame.

b21b0ef

Correctly fix BlendMode.Subtractive alpha handling.

477d692

pchote dismissed teinarss’s stale review via 853a338 August 31, 2019 17:41

pchote force-pushed the renderer-framebuffer branch from 013e7bc to 853a338 Compare August 31, 2019 17:41

pchote removed the PR: Changes requested label Aug 31, 2019

pchote added 3 commits August 31, 2019 18:43

Allow FrameBuffer clear color to be customized.

db1bcd7

Render via an intermediate frame buffer.

e738273

Save screenshots via the frame buffer.

1ffbb8e

pchote force-pushed the renderer-framebuffer branch from 853a338 to 1ffbb8e Compare August 31, 2019 17:43

abcdefg30 approved these changes Sep 3, 2019

View reviewed changes

teinarss approved these changes Sep 4, 2019

View reviewed changes

teinarss merged commit 1d106e7 into OpenRA:bleed Sep 4, 2019

pchote deleted the renderer-framebuffer branch September 14, 2019 08:29

pchote mentioned this pull request Nov 3, 2019

Render world via an intermediate FrameBuffer #17308

Merged

pchote mentioned this pull request Dec 5, 2019

Implement "Battlefield Camera" setting and smooth zooming #17424

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render via an intermediate framebuffer #16996

Render via an intermediate framebuffer #16996

pchote commented Aug 26, 2019 •

edited

pchote commented Aug 27, 2019

pchote commented Aug 27, 2019

pchote Aug 27, 2019

chrisforbes Aug 31, 2019

pchote commented Aug 28, 2019

teinarss left a comment •

edited

pchote commented Aug 28, 2019

pchote commented Aug 31, 2019

teinarss left a comment

chrisforbes Aug 31, 2019

chrisforbes Aug 31, 2019

pchote Aug 31, 2019

teinarss commented Sep 1, 2019

pchote commented Sep 3, 2019

teinarss commented Sep 4, 2019

Render via an intermediate framebuffer #16996

Render via an intermediate framebuffer #16996

Conversation

pchote commented Aug 26, 2019 • edited

pchote commented Aug 27, 2019

pchote commented Aug 27, 2019

pchote Aug 27, 2019

Choose a reason for hiding this comment

chrisforbes Aug 31, 2019

Choose a reason for hiding this comment

pchote commented Aug 28, 2019

teinarss left a comment • edited

Choose a reason for hiding this comment

pchote commented Aug 28, 2019

pchote commented Aug 31, 2019

teinarss left a comment

Choose a reason for hiding this comment

chrisforbes Aug 31, 2019

Choose a reason for hiding this comment

chrisforbes Aug 31, 2019

Choose a reason for hiding this comment

pchote Aug 31, 2019

Choose a reason for hiding this comment

teinarss commented Sep 1, 2019

pchote commented Sep 3, 2019

teinarss commented Sep 4, 2019

pchote commented Aug 26, 2019 •

edited

teinarss left a comment •

edited