Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crushable logic for actors in cell #17037

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@teinarss
Copy link
Contributor

commented Sep 2, 2019

Problem was that the crushable logic for the locomotor cache was using AND when constructing the bits for an actor. When the logic before an actor was crushable when one of the crushable traits returned true.
Fixes #17033

@teinarss teinarss added this to the Next Release milestone Sep 5, 2019

@reaperrr
Copy link
Contributor

left a comment

Looks good to me

@pchote
pchote approved these changes Sep 7, 2019
Copy link
Member

left a comment

Logic change looks correct and didn't notice anything obviously wrong ingame.

@pchote pchote merged commit c13fb80 into OpenRA:bleed Sep 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.